chore: cleanup images, officially retire OpaqueImageView #11264
Conversation
|
ready for review but please don't merge until I do more testing! |
brainbicycle
requested review from
MounirDhahri,
gkartalis and
damassi
and removed request for
MounirDhahri
| @@ -44,13 +43,12 @@ export const MyCollectionImageView: React.FC<MyCollectionImageViewProps> = ({ | |||
| const targetURL = imageURL.replace(":version", "large") | |||
| return ( | |||
| <Flex testID="Image-Remote"> | |||
| <OpaqueImageView | |||
| imageURL={targetURL} | |||
| retryFailedURLs | |||
There was a problem hiding this comment.
this has not done anything since we retired the native image view but maybe we want to bring some functionality like this back? https://github.com/artsy/eigen/pull/10201/files#diff-fcc7543a59c408cd4d4824eaea1df3a25d70e6c7dbdbbee85d3ef130f446083f
| @@ -365,10 +365,10 @@ export const ImageZoomView = | |||
| transform, | |||
| }} | |||
| > | |||
| <OpaqueImageView | |||
| noAnimation | |||
There was a problem hiding this comment.
likewise believe since we are passing an imageURL this was having no effect since soft retiring OpaqueImageView but I will take a look and make sure
| width={60} | ||
| height={40} | ||
| imageURL={iconUrl} | ||
| placeholderBackgroundColor="white" |
There was a problem hiding this comment.
likewise only worked with native image view but I think background colors should be standard across app anyway
|
i spot checked a bunch of places but not all but didn't see anything at all broken, but please let me know if anything looks amiss 🙏 |
This PR resolves PHIRE-1401
Description
Now that we have been using palette image under the hood for some time it should be safe to update all our components to use palette-image directly and get rid of the old OpaqueImageView code.
To do
Follow-ups
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.