-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(fix): fix nightly, upgrade xcode to 16 #11181
Conversation
This reverts commit 24d9a9a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these screenshots for View in Room seem kind of useless / not showing what the test expects, not sure if they were before my update, maybe should get rid of or check if I broke something
@@ -161,7 +161,7 @@ const checkPodDependenciesAreUpToDate = async () => { | |||
// https://github.com/square/cocoapods-check/issues/18 | |||
// This is a bug for some react native deps in cocoapods-check | |||
// might be a nice OSS contribution opportunity! | |||
const knownException = `~RNImageCropPicker, ~RNPermissions, ~React-Codegen\n[!] \`pod install\` will install 3 Pods.` | |||
const knownException = `~RNFastImage, ~RNImageCropPicker, ~RNPermissions, ~RNShare, ~React-RCTFabric, ~ReactCodegen, ~react-native-blob-util, ~react-native-view-shot\n[!] \`pod install\` will install 8 Pods.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
little bonus fix issue with yarn doctor
causing it always to report pods not installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Brian! 🙌
This PR resolves []
Description
Updates ci and local tooling to use Xcode 16.1.
I tried this earlier to workaround some build failures but didn't make all the necessary changes so broke nightlies 😬
This tries to do things the right way.
If anyone needs to do an Xcode upgrade in the future:
haveValidSnapshot
torecordSnapshot
(there is probably an easier way of doing this check docs on NimbleSnapshots) - commit this separately (e.g. "revert me: record new snapshots")Common bonus issues
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.