feat: extract non cacheable fields out of grid items #11093
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import { useEffect, useState } from "react" | ||
| import { fetchQuery, graphql } from "react-relay" | ||
|
|
||
| export const fetchArtworkNonCacheableFields = async (artworkID: string) => { |
There was a problem hiding this comment.
I understand the quick win here but I think we could follow Force's approach https://github.com/artsy/force/pull/14533/files#diff-5a8e92cd05a6757b15a42e921874b7ab7ff1fc4471985e2736ff02525a8724adR163
fetchQuery definition points out of using it outside of React, so inside React elements we should aim for splitting the smaller parts into standalone query elements like @mzikherman did in the PR
There was a problem hiding this comment.
your comment makes sense. I don't remember why I've done it that way actually.
Anyway, I am not happy with both approaches because both would lead to n queries for each grid and I want to investigate ways to avoid that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.