Merge pull request alexguan#43 from lightswitch05/feature/improve-cov…

…erage Improved code coverage
artofspeed · Feb 10, 2017 · b462db5 · b462db5
2 parents 9eeb2e7 + 70f2b9f
commit b462db5
Show file tree

Hide file tree

Showing 6 changed files with 360 additions and 3 deletions.
diff --git a/lib/Exception.js b/lib/Exception.js
@@ -60,8 +60,8 @@ function validateCode(code) {
  * @private
  * @param code {Number} Exception code.
  * @param name {String} Name of the exception.
- * @param path {String} Node path of the exception, optional.
- * @param ctor {String} The function to start in stack trace.
+ * @param [path] {String} Node path of the exception, optional.
+ * @param ctor {Function} The function to start in stack trace.
  */
 function Exception(code, name, path, ctor) {
     if (!ctor) {

diff --git a/test/lib/Event.test.js b/test/lib/Event.test.js
@@ -64,7 +64,7 @@ describe('Event', function () {
     });
 
     describe('toString', function () {
-        it('should return the correctly formatted string.', function () {
+        it('should return the correctly formatted string with a path.', function () {
             var e = Event.create({
                 type : Event.NODE_CREATED,
                 path : '/test'
@@ -74,5 +74,15 @@ describe('Event', function () {
                 'NODE_CREATED[' + Event.NODE_CREATED + ']@/test'
             );
         });
+
+        it('should return the correctly formatted string without a path.', function () {
+            var e = Event.create({
+                type : Event.NODE_CREATED
+            });
+
+            expect(e.toString()).to.equal(
+                'NODE_CREATED[' + Event.NODE_CREATED + ']'
+            );
+        });
     });
 });
diff --git a/test/lib/Exception.test.js b/test/lib/Exception.test.js
@@ -12,6 +12,17 @@ var Exception = require('../../lib/Exception.js');
 
 
 describe('Exception', function () {
+    it('does not require path', function () {
+        var exception = new Exception(0, 'name', function(){});
+        expect(exception.path).to.be.undefined;
+    });
+
+    it('requires ctor to be a function', function () {
+        expect(function () {
+            new Exception(0, 'name', null);
+        }).to.throw('ctor must be a function.');
+    });
+
     describe('create', function () {
         it('should only accept number code', function () {
             expect(function () {

diff --git a/test/lib/Path.test.js b/test/lib/Path.test.js
@@ -70,5 +70,11 @@ describe('Path', function () {
                 Path.validate('/a..b');
             }).to.not.throw('relative path');
         });
+
+        it('should accept root path', function () {
+            expect(function () {
+                Path.validate('/');
+            }).to.not.throw('relative path');
+        });
     });
 });
diff --git a/test/lib/State.test.js b/test/lib/State.test.js
@@ -22,5 +22,20 @@ describe('State', function () {
             expect(State.EXPIRED).to.exist;
         });
     });
+
+    it('gets the sate name', function () {
+        expect(State.DISCONNECTED.getName()).to.equal('DISCONNECTED');
+    });
+
+    it('gets the sate code', function () {
+        expect(State.DISCONNECTED.getCode()).to.equal(0);
+    });
+
+    it('represents the state as a string', function () {
+        var state = State.DISCONNECTED;
+        var expectedString = state.getName() + '[' + state.getCode() + ']';
+
+        expect(String(State.DISCONNECTED)).to.equal(expectedString);
+    });
 });