More refactor around ExtendedTime
#979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Oct 23, 2024
| @@ -33,6 +33,10 @@ func (k *KindDetails) EnsureExtendedTimeDetails() error { | |||
| return fmt.Errorf("extended time details is not set") | |||
| } | |||
|
|
|||
| if k.ExtendedTimeDetails.Format == "" { | |||
There was a problem hiding this comment.
Added an additional guardrail to ensure we don't do time.Format("")
Tang8330
commented
Oct 23, 2024
| @@ -81,8 +81,3 @@ func (e *ExtendedTime) GetTime() time.Time { | |||
| func (e *ExtendedTime) GetNestedKind() NestedKind { | |||
| return e.nestedKind | |||
| } | |||
|
|
|||
| func (e *ExtendedTime) String(overrideFormat string) string { | |||
Tang8330
commented
Oct 23, 2024
| @@ -119,18 +119,18 @@ func (s *Store) writeTemporaryTableFile(tableData *optimization.TableData, newTa | |||
| writer.Comma = '\t' | |||
|
|
|||
| columns := tableData.ReadOnlyInMemoryCols().ValidColumns() | |||
| for _, value := range tableData.Rows() { | |||
| var row []string | |||
| for _, row := range tableData.Rows() { | |||
There was a problem hiding this comment.
Renamed the variable so it's less confusing
Tang8330
changed the title
String() methodExtendedTime
Tang8330
commented
Oct 23, 2024
| return nil, err | ||
| } | ||
|
|
||
| return castedValue.GetTime().Format(s.kd.ExtendedTimeDetails.Format), nil |
There was a problem hiding this comment.
Use the column format instead of .String() which relies on the value format.
danafallon
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes, including removing the
.String()method.I added comments to every major change in the PR.