More refactor around extended time #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Oct 23, 2024
| @@ -10,16 +10,20 @@ import ( | |||
|
|
|||
| type Date struct{} | |||
|
|
|||
| func (Date) ToKindDetails() typing.KindDetails { | |||
| return typing.NewExtendedTimeDetails(typing.ETime, ext.DateKindType, "") | |||
| func (Date) layout() string { | |||
There was a problem hiding this comment.
Specifying a layout
Tang8330
changed the title
danafallon
reviewed
Oct 23, 2024
| @@ -284,14 +284,14 @@ func TestField_ParseValue(t *testing.T) { | |||
| field := Field{Type: Int64, DebeziumType: MicroTime} | |||
| value, err := field.ParseValue(int64(54720000000)) | |||
| assert.NoError(t, err) | |||
| assert.Equal(t, "15:12:00.000000", value.(*ext.ExtendedTime).String("")) | |||
| assert.Equal(t, "15:12:00.000000", value.(*ext.ExtendedTime).GetTime().Format("15:04:05.000000")) | |||
There was a problem hiding this comment.
Could we use MicroTime{}.layout() here instead of hardcoding the layout?
There was a problem hiding this comment.
I think we'll run into a cyclical dependency import since it's not in the same package :(
danafallon
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtendedTime.String()to go throughGetTime()