[ExtendedTime] More clean up #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tang8330
commented
Oct 21, 2024
•
Tang8330
commented
- Addressing PR comments
- Adding the concept of default layout
- Removing NestedKind variables (that were seldomly used)
Tang8330
changed the title
Tang8330
commented
Oct 21, 2024
| @@ -11,18 +11,22 @@ import ( | |||
|
|
|||
| type Time struct{} | |||
|
|
|||
| func (Time) ToKindDetails() typing.KindDetails { | |||
| return typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, "") | |||
| func (Time) layout() string { | |||
There was a problem hiding this comment.
Addresses #967 (comment)
Tang8330
changed the title
danafallon
reviewed
Oct 22, 2024
danafallon
reviewed
Oct 22, 2024
danafallon
reviewed
Oct 22, 2024
lib/typing/ext/time.go
Outdated
| func (e ExtendedTime) MarshalJSON() ([]byte, error) { | ||
| return json.Marshal(e.String("")) | ||
| return json.Marshal(e.ts) |
There was a problem hiding this comment.
Is this not taking the NestedKind's type and format into account?
There was a problem hiding this comment.
Ah yeah. I'm purposefully moving away from using the ExtendedTime's nested type and format into account.
My goal is to eventually make ExtendedTime just an alias for time.Time.
MarshalJSON was created specifically for nested MongoDB objects and this code is consistent with how Mongo marshals Datetime https://github.com/mongodb/mongo-go-driver/blob/c91b204cc72025ea0c8d0845b84816b8c9e88903/bson/primitive.go#L59-L61
There was a problem hiding this comment.
Actually, let me get it to look identical to MongoDB's
danafallon
reviewed
Oct 22, 2024
danafallon
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.