Moving types around #927
Merged
Moving types around #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Sep 25, 2024
| @@ -38,32 +38,6 @@ func TestBigQuery_DSN(t *testing.T) { | |||
| assert.Equal(t, "bigquery://project/eu/dataset", b.DSN()) | |||
| } | |||
|
|
|||
| func TestKafka_BootstrapServers(t *testing.T) { | |||
There was a problem hiding this comment.
Duplicate test (this is tested at the bottom of this file).
lib/config/destination_types.go
Outdated
| Database string `yaml:"database"` | ||
| } | ||
|
|
||
| type BigQuery struct { |
There was a problem hiding this comment.
Alphabetize BigQuery -> Snowflake?
nathan-artie
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality changes.
types.goordestination_types.godestinations.go