Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snowflake] Address idle action item follow ups #907

Merged
merged 9 commits into from
Sep 17, 2024

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Sep 17, 2024

Follow ups from: #906

@Tang8330 Tang8330 marked this pull request as ready for review September 17, 2024 14:51
@Tang8330 Tang8330 requested a review from a team as a code owner September 17, 2024 14:51
// 5 regular ones and then 1 additional one to re-establish auth and another one for dropping the temporary table
baseline := 5
assert.Equal(s.T(), baseline+2, s.fakeStageStore.ExecCallCount(), "called merge")
assert.NoError(s.T(), s.stageStore.Merge(tableData), "transient errors like auth errors will be retried")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this description still relevant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'll remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@Tang8330 Tang8330 merged commit 2440919 into master Sep 17, 2024
3 checks passed
@Tang8330 Tang8330 deleted the improve-snowflake-idle branch September 17, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants