Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Default Values] Add *decimal.Decimal + explicit return for STRING #871

Merged
merged 2 commits into from
Sep 4, 2024
Merged

[Default Values] Add *decimal.Decimal + explicit return for STRING #871

merged 2 commits into from
Sep 4, 2024

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Sep 3, 2024 •
edited
Loading

Checked our logs and found that we weren't being explicit about capturing decimal.Decimal

@Tang8330 Tang8330 changed the title [Default Values] Add *decimal.Decimal. [Default Values] Add *decimal.Decimal + explicit return for STRING Sep 3, 2024
@Tang8330 Tang8330 marked this pull request as ready for review September 3, 2024 23:37
@Tang8330 Tang8330 requested a review from a team as a code owner September 3, 2024 23:37
@Tang8330 Tang8330 merged commit 836af1e into master Sep 4, 2024
3 checks passed
@Tang8330 Tang8330 deleted the default-value-types branch September 4, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-artie nathan-artie nathan-artie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tang8330 @nathan-artie