[Typing] Remove the implicit JSON check #826
Closed
+34
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Jul 30, 2024
|
|
||
| return string(colValBytes), nil | ||
| isArray := reflect.ValueOf(colVal).Kind() == reflect.Slice |
There was a problem hiding this comment.
Lifted this from typing.String.Kind
Tang8330
commented
Jul 30, 2024
| if err != nil { | ||
| return "", err | ||
| } | ||
| if strings.Contains(fmt.Sprint(colVal), constants.ToastUnavailableValuePlaceholder) { |
There was a problem hiding this comment.
No need to create a map just to have it marshaled, we can do it ourselves. Also the if statement is a no-op given the case.
Tang8330
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already parsing JSON here. This PR removes the need for us to implicitly check if a string is a JSON object or not.
We will only label something as JSON if the schema provided, it or payload itself is a
map.