Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Alpine image to 3.20 #782

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Upgrade Alpine image to 3.20 #782

merged 3 commits into from
Jun 28, 2024

Conversation

nathan-artie
Copy link
Contributor

No description provided.

@nathan-artie nathan-artie requested a review from Tang8330 June 28, 2024 07:39
Dockerfile Outdated
@@ -1,14 +1,13 @@
FROM --platform=linux/amd64 golang:1.22-alpine AS builder
FROM --platform=linux/amd64 golang:1.22-alpine3.20 AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file still being used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm guessing it's not since we have a dockerfile just for goreleaser and that's what we use for builds.

@nathan-artie nathan-artie merged commit cc59256 into master Jun 28, 2024
1 check passed
@nathan-artie nathan-artie deleted the nv/alpine-3.20 branch June 28, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants