[debezium] Return apd.Decimal from DecodeDecimal
#765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Jun 26, 2024
| @@ -132,6 +112,7 @@ func TestEncodeDecimalWithScale(t *testing.T) { | |||
| assert.Equal(t, "-145.1830000000000090", mustEncodeAndDecodeDecimal("-145.183000000000009", 16)) | |||
|
|
|||
| assert.Equal(t, "-9063701308.217222135", mustEncodeAndDecodeDecimal("-9063701308.217222135", 9)) | |||
| assert.Equal(t, "-74961544796695.89960242", mustEncodeAndDecodeDecimal("-74961544796695.89960242", 8)) | |||
There was a problem hiding this comment.
This test fails on master.
nathan-artie
changed the title
apd.Decimal for DecodeDecimalapd.Decimal from DecodeDecimal
nathan-artie
commented
Jun 26, 2024
| @@ -129,9 +129,9 @@ func TestRowToMessage(t *testing.T) { | |||
| "c_float_int32": int32(1234), | |||
| "c_float_int64": int64(1234), | |||
| "c_float_string": "4444.55555", | |||
| "c_numeric": decimal.NewDecimal(nil, 5, big.NewFloat(3.1415926)), | |||
| "c_numeric": decimal.NewDecimal(nil, numbers.MustParseDecimal("3.14159")), | |||
There was a problem hiding this comment.
We now rely on the exponent of the decimal instead of passing in a scale, so the decimal places here were trimmed to 5 to match the previous scale.
nathan-artie
commented
Jun 26, 2024
| @@ -19,7 +19,7 @@ func BenchmarkDecodeDecimal_P64_S10(b *testing.B) { | |||
| assert.NoError(b, err) | |||
| dec, err := field.DecodeDecimal(bytes) | |||
| assert.NoError(b, err) | |||
| assert.Equal(b, "123456789012345678901234567890123456789012345678901234.1234567889", dec.Value()) | |||
| assert.Equal(b, "123456789012345678901234567890123456789012345678901234.1234567890", dec.String()) | |||
There was a problem hiding this comment.
This was decoding incorrectly, the unscaled value is 1234567890123456789012345678901234567890123456789012341234567890
There was a problem hiding this comment.
Which makes sense since this number is just 1234567890 repeating (with a 1234 before the decimal point).
danafallon
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
DecodeDecimalis usingbig.Floatthere are small discrepancies with decoding certain numbers. For example, decoding the binary representation of-74961544796695.89960242produces-74961544796695.89960241.