When soft deleting, preserve previous values if we have them in memory #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danafallon
commented
Jun 25, 2024
| @@ -131,17 +131,27 @@ func (t *TableData) InsertRow(pk string, rowData map[string]any, delete bool) { | |||
| prevRow, isOk := t.rowsData[pk] | |||
| if isOk { | |||
There was a problem hiding this comment.
(hide whitespace to make the diff simpler)
Tang8330
reviewed
Jun 25, 2024
Tang8330
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of not clearing out the values of a row when it's soft deleted.
If a row is updated and then deleted before the next flush, we have its previous values in memory so we can use those and just add the deleted flag.