[debezium] Change function signature of EncodeDecimal
#761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Jun 25, 2024
|
|
||
| // EncodeDecimal is used to encode a [apd.Decimal] to [org.apache.kafka.connect.data.Decimal]. | ||
| // The scale of the value (which is the negated exponent of the decimal) is returned as the second argument. | ||
| func EncodeDecimal(decimal *apd.Decimal) ([]byte, int32) { |
There was a problem hiding this comment.
I chose to use int32 for the scale because that's both what apd.Decimal uses as well as the wire representation of org.apache.kafka.connect.data.Decimal.
There was a problem hiding this comment.
Unless you are planning to have reader call EncodeDecimal and EncodeDecimalWithScale depending on whether we know the scale or not
There was a problem hiding this comment.
Reader is going to call both functions in different places.
There was a problem hiding this comment.
Hah your second comment didn't show up for me when I responded!
nathan-artie
changed the title
EncodeDecimal
Tang8330
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EncodeDecimalis only called by Reader in two places, and in one of those places we already have code to determine the scale, which is something we can simplify if we have aapd.Decimal, so rather than depend on Transfer to parse strings into encodedorg.apache.kafka.connect.data.Decimals we'll let Reader handle the parsing toapd.Decimaland just let Transfer handle the encoding.