Use uint16 for EncodeDecimal
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,7 +86,7 @@ func TestEncodeDecimal(t *testing.T) { | |||
| for _, testCase := range testCases { | |||
| encodedValue, err := EncodeDecimal(testCase.value, testCase.scale) | |||
| if testCase.expectedErr == "" { | |||
| decodedValue := DecodeDecimal(encodedValue, nil, testCase.scale) | |||
| decodedValue := DecodeDecimal(encodedValue, nil, int(testCase.scale)) | |||
There was a problem hiding this comment.
It'd be nice to make make DecodeDecimal and Decimal use int16 too.
There was a problem hiding this comment.
Yeah I tried, it's pretty hard
There was a problem hiding this comment.
What about int64 then?
nathan-artie
approved these changes
Jun 22, 2024
|
The precision isn't the problem, it's the fact that we have lots of code
references that will need to specify
…On Fri, Jun 21, 2024 at 6:24 PM Nathan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/debezium/decimal_test.go
<#749 (comment)>:
> @@ -86,7 +86,7 @@ func TestEncodeDecimal(t *testing.T) {
for _, testCase := range testCases {
encodedValue, err := EncodeDecimal(testCase.value, testCase.scale)
if testCase.expectedErr == "" {
- decodedValue := DecodeDecimal(encodedValue, nil, testCase.scale)
+ decodedValue := DecodeDecimal(encodedValue, nil, int(testCase.scale))
What about int64 then?
—
Reply to this email directly, view it on GitHub
<#749 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBVGKGRDUDXMZ5NFLIMMK3ZITG5RAVCNFSM6AAAAABJW7AST2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZTGU2TMMJXGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.