[bigquery] Add scaffolding for the Storage Write API #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Jun 13, 2024
| // Structs from relational and Mongo are different. | ||
| // MongoDB will return the native objects back such as `map[string]any{"hello": "world"}` | ||
| // Relational will return a string representation of the struct such as `{"hello": "world"}` | ||
| func EncodeStructToJSONString(value any) (string, error) { |
There was a problem hiding this comment.
Will need this for the Storage Write API.
nathan-artie
commented
Jun 13, 2024
nathan-artie
commented
Jun 13, 2024
| ProjectID string `yaml:"projectID"` | ||
| Location string `yaml:"location"` | ||
| BatchSize int `yaml:"batchSize"` | ||
| UseStorageWriteAPI bool `yaml:"__useStorageWriteAPI"` // Not officially supported yet. |
There was a problem hiding this comment.
For config settings that are not intended for production use I think it's nice to prefix them with "__" to indicate that the are not officially supported, that way we can get rid of them without breaking backwards compatibility and having to bump the minor version.
Tang8330
reviewed
Jun 13, 2024
|
|
||
| stringValue := string(bytes) | ||
| if strings.Contains(stringValue, constants.ToastUnavailableValuePlaceholder) { | ||
| slog.Error("encoded JSON value contains the toast unavailable value placeholder") |
There was a problem hiding this comment.
This should return this too
return fmt.Sprintf(`{"key":"%s"}`, constants.ToastUnavailableValuePlaceholder), nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking out some parts of the Storage Write API PR I'm working out.