Pass Dialect to Column.DefaultValue
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
May 2, 2024
| @@ -25,7 +25,7 @@ func BackfillColumn(cfg config.Config, dwh destination.DataWarehouse, column col | |||
| } | |||
|
|
|||
| additionalDateFmts := cfg.SharedTransferConfig.TypingSettings.AdditionalDateFormats | |||
| defaultVal, err := column.DefaultValue(&columns.DefaultValueArgs{Escape: true, DestKind: dwh.Label()}, additionalDateFmts) | |||
| defaultVal, err := column.DefaultValue(dwh.Dialect(), additionalDateFmts) | |||
There was a problem hiding this comment.
This is the only place we call DefaultValue so I removed the Escape argument.
nathan-artie
commented
May 2, 2024
| return fmt.Sprintf("JSON_PARSE(%s)", stringutil.Wrap(c.defaultValue, false)), nil | ||
| case constants.Snowflake: | ||
| case sql.SnowflakeDialect: |
There was a problem hiding this comment.
@Tang8330 it doesn't seem like we're doing anything for MS SQL here, do we need a case for it?
There was a problem hiding this comment.
Yeah we're not. We don't support backfill default values in MSSQL yet.
Do you want to leave a comment?
Tang8330
approved these changes
May 2, 2024
nathan-artie
changed the title
Dialog to Column.DefaultValueDialect to Column.DefaultValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.