Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standing up guardrails for Invalid Cols #512

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Apr 29, 2024

Problem

If we fail to understand the data type from source or destination, we are marking the column as Invalid and we do not copy the data over to the destination. This is a silent failure, and this PR makes that an explicit failure so we can be better at data type mapping.

Change

  1. We are now going to error out if we fail to map a data type to a data type in the destination
  2. We are going to error out if we are unable to understand the data type from the destination after we run describe table

@Tang8330 Tang8330 changed the title Checkpoint. Standing up guardrails for Invalid Cols Apr 29, 2024
@Tang8330 Tang8330 marked this pull request as ready for review April 29, 2024 18:04
@Tang8330 Tang8330 merged commit 81a45f0 into master Apr 29, 2024
1 check passed
@Tang8330 Tang8330 deleted the guardrails-for-invalid-cols branch April 29, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants