[typing] Pass DestinationKind to Column.Name
#503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Apr 24, 2024
| @@ -198,7 +194,11 @@ func (c *Columns) GetColumnsToUpdate(uppercaseEscNames bool, args *NameArgs) []s | |||
| continue | |||
| } | |||
|
|
|||
| cols = append(cols, col.Name(uppercaseEscNames, args)) | |||
| if args == nil { | |||
There was a problem hiding this comment.
This is a stopgap, will look at passing a *constants.DestinationKind pointer to this method.
There was a problem hiding this comment.
Can we create another function instead?
There was a problem hiding this comment.
GetColumnsToUpdateRaw or something?
There was a problem hiding this comment.
Maybe, I'll look into it in the next PR, I don't want to grow the scope of this PR.
nathan-artie
changed the title
Column.Nameconstants.DestinationKind to Column.Name
nathan-artie
changed the title
constants.DestinationKind to Column.NameDestinationKind to Column.Name
Tang8330
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.