Improve Snowflake Dedupe. #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clients/snowflake/snowflake.go
Outdated
| return err | ||
| var parts []string | ||
| parts = append(parts, fmt.Sprintf("CREATE OR REPLACE TRANSIENT TABLE %s AS (SELECT * FROM %s QUALIFY ROW_NUMBER() OVER (PARTITION BY by %s ORDER BY %s) = 2)", | ||
| stagingTableID.Table(), |
There was a problem hiding this comment.
Use stagingTableID.FullyQualifiedName() or escape stagingTableID.Table() with sql.EscapeName
There was a problem hiding this comment.
This is a transient table, it doesn't belong to a schema or database.
clients/snowflake/snowflake.go
Outdated
| for _, pk := range orderColsToIterate { | ||
| orderByCols = append(orderByCols, fmt.Sprintf("%s ASC", pk)) | ||
| } | ||
|
|
||
| fqTableName := tableID.FullyQualifiedName() |
There was a problem hiding this comment.
tableID.FullyQualifiedName() is so short now that it doesn't take arguments we could just inline it instead of assigning to fqTableName.
clients/snowflake/snowflake.go
Outdated
|
|
||
| parts = append(parts, fmt.Sprintf("DELETE FROM %s t1 USING %s t2 WHERE %s", | ||
| fqTableName, | ||
| stagingTableID.Table(), |
There was a problem hiding this comment.
Ditto escape or use FullyQualifiedName().
| { | ||
| // Dedupe with one primary key + no `__artie_updated_at` flag. | ||
| tableID := NewTableIdentifier("db", "public", "customers") | ||
| stagingTableID := shared.TempTableID(tableID, strings.ToLower(stringutil.Random(5))) |
There was a problem hiding this comment.
Might be nice to have two methods TempTableID and TempTableIDWithSuffix.
|
@nathan-artie Take another look? Should be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving our Snowflake dedupe process which will minimize data movement from the target table, which will execute faster and more reliably.