[sql] Kill NameArgs.Escape
#484
Conversation
| DestKind constants.DestinationKind | ||
| } | ||
|
|
||
| // symbolsToEscape are additional keywords that we need to escape | ||
| var symbolsToEscape = []string{":"} | ||
|
|
||
| func EscapeNameIfNecessary(name string, uppercaseEscNames bool, args *NameArgs) string { | ||
| if args == nil || !args.Escape { |
There was a problem hiding this comment.
Is this safe? What about callers that expect the column to not be escaped?
There was a problem hiding this comment.
There aren't any callers that expect this column not to be escaped.
There was a problem hiding this comment.
args.Escape is always true.
There was a problem hiding this comment.
Do you want to kill NameArgs and just pass DestKind?
There was a problem hiding this comment.
I thought about that, and that's what I originally wanted to do, but it's a little tricky because sometimes args is null and it's annoying to create a pointer to DestinationKind. Maybe I'll do that anyways since it's a bit safer.
There was a problem hiding this comment.
Tried again and it ends up being a bigger lift than I want to do right now, will look into it some other time.
Escapeis always true for non-test code and only ever false in test code.