Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snowflake] Pass TableIdentifier to addPrefixToTableName #480

Merged
merged 9 commits into from
Apr 22, 2024

Conversation

nathan-artie
Copy link
Contributor

No description provided.

@nathan-artie nathan-artie marked this pull request as ready for review April 22, 2024 00:21
@nathan-artie nathan-artie requested a review from Tang8330 April 22, 2024 00:21
// addPrefixToTableName will take a [types.TableIdentifier] and add a prefix in front of the table.
// This is necessary for `PUT` commands.
func addPrefixToTableName(tableID types.TableIdentifier, prefix string) string {
return tableID.WithTable(prefix + tableID.Table()).FullyQualifiedName()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer. Nice one

@nathan-artie nathan-artie merged commit 98612c4 into master Apr 22, 2024
1 check passed
@nathan-artie nathan-artie deleted the nv/add-prefix-table-name branch April 22, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants