-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return errors from Event.GetData
and Event.GetColumns
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
changed the title
Hard error
Return error from Apr 18, 2024
Event.GetData
and Event.GetColumns
nathan-artie
changed the title
Return error from
Return errors from Apr 18, 2024
Event.GetData
and Event.GetColumns
Event.GetData
and Event.GetColumns
nathan-artie
commented
Apr 18, 2024
This PR looks good, let's wait until next week to merge this since we're still seeing failures in logs |
Signed-off-by: Nathan <[email protected]>
Tang8330
reviewed
Apr 22, 2024
processes/consumer/process.go
Outdated
evt, err := event.ToMemoryEvent(_event, pkMap, topicConfig.tc, cfg.Mode) | ||
if err != nil { | ||
tags["what"] = "to_mem_event_err" | ||
return "", err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wrap this error?
Tang8330
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.