Change log level to error for merge failures #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
reviewed
Feb 8, 2024
processes/consumer/flush.go
Outdated
| @@ -90,7 +90,7 @@ func Flush(ctx context.Context, inMemDB *models.DatabaseData, dest destination.B | |||
|
|
|||
| if err != nil { | |||
| tags["what"] = "merge_fail" | |||
| slog.With(logFields...).Warn(fmt.Sprintf("Failed to execute %s...not going to flush memory", action), slog.Any("err", err)) | |||
| slog.Error(fmt.Sprintf("Failed to execute %s...not going to flush memory", action), append(logFields, slog.Any("err", err))...) | |||
There was a problem hiding this comment.
Also, any reason not to just change .Warn to .Error?
slog.With(logFields...).Error(fmt.Sprintf("Failed to execute %s...not going to flush memory", action), slog.Any("err", err))There was a problem hiding this comment.
There was a problem hiding this comment.
I can just do the simple level change for now.
Tang8330
approved these changes
Feb 8, 2024
This reverts commit b65da2d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.