Skip to content

Commit

Permalink
Add comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
Tang8330 committed Aug 16, 2024
1 parent a05fd15 commit f114966
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion processes/consumer/flush.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ func flush(ctx context.Context, dest destination.Baseline, metricsClient base.Cl
}

if err = commitOffset(ctx, _tableData.TopicConfig().Topic, _tableData.PartitionsToLastMessage); err != nil {
return fmt.Errorf("failed to commit offset: %w", err)
// Failure to commit Kafka offset shouldn't force the whole flush process to retry.
slog.Warn("Failed to commit Kafka offset", slog.Any("err", err), slog.String("tableName", _tableName))
}

return nil
Expand Down

0 comments on commit f114966

Please sign in to comment.