Checkpoint.

artie-labs · Oct 7, 2024 · e43222c · e43222c
1 parent bed2c1f
commit e43222c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/clients/databricks/dialect/dialect.go b/clients/databricks/dialect/dialect.go
@@ -160,7 +160,7 @@ func (d DatabricksDialect) BuildSweepFilesFromVolumesQuery(dbName, schemaName, v
 }
 
 func (d DatabricksDialect) BuildRemoveFileFromVolumeQuery(filePath string) string {
-	return fmt.Sprintf("REMOVE '%s", filePath)
+	return fmt.Sprintf("REMOVE '%s'", filePath)
 }
 
 func (d DatabricksDialect) GetDefaultValueStrategy() sql.DefaultValueStrategy {

diff --git a/clients/databricks/store.go b/clients/databricks/store.go
@@ -190,14 +190,15 @@ func (s Store) writeTemporaryTableFile(tableData *optimization.TableData, newTab
 }
 
 func (s Store) SweepTemporaryTables() error {
+	// TODO: Update interface to include context
+	ctx := driverctx.NewContextWithStagingInfo(context.Background(), []string{"/var"})
 	tcs, err := s.cfg.TopicConfigs()
 	if err != nil {
 		return err
 	}
 
 	// Remove the temporary files from volumes
 	for _, tc := range tcs {
-		fmt.Println("s.dialect().BuildSweepFilesFromVolumesQuery(tc.Database, tc.Schema, s.volume)", s.dialect().BuildSweepFilesFromVolumesQuery(tc.Database, tc.Schema, s.volume))
 		rows, err := s.Query(s.dialect().BuildSweepFilesFromVolumesQuery(tc.Database, tc.Schema, s.volume))
 		if err != nil {
 			return fmt.Errorf("failed to sweep files from volumes: %w", err)
@@ -215,7 +216,7 @@ func (s Store) SweepTemporaryTables() error {
 			}
 
 			if vol.ShouldDelete() {
-				if _, err = s.Exec(s.dialect().BuildRemoveFileFromVolumeQuery(vol.Path())); err != nil {
+				if _, err = s.ExecContext(ctx, s.dialect().BuildRemoveFileFromVolumeQuery(vol.Path())); err != nil {
 					return fmt.Errorf("failed to delete volume: %w", err)
 				}
 			}