Adding more tests.

artie-labs · Oct 22, 2024 · d982d8e · d982d8e
1 parent ee4d09e
commit d982d8e
Showing 1 changed file with 21 additions and 4 deletions.
diff --git a/lib/debezium/converters/time_test.go b/lib/debezium/converters/time_test.go
@@ -162,14 +162,31 @@ func TestConvertTimeWithTimezone(t *testing.T) {
 		assert.ErrorContains(t, err, `failed to parse "23:02": parsing time`)
 	}
 	{
-		// What Debezium + Reader would produce
+		// What Debezium + Reader would produce (microsecond precision)
 		val, err := TimeWithTimezone{}.Convert("23:02:06.745116Z")
-		ts, isOk := val.(*ext.ExtendedTime)
-		assert.True(t, isOk)
 		assert.NoError(t, err)
 
 		expectedTs := ext.NewExtendedTime(time.Date(0, 1, 1, 23, 2, 6, 745116000, time.UTC), ext.TimeKindType, "15:04:05.999999Z")
-		assert.Equal(t, expectedTs, ts)
+		assert.Equal(t, expectedTs, val.(*ext.ExtendedTime))
+		assert.Equal(t, "23:02:06.745116Z", val.(*ext.ExtendedTime).String(""))
+	}
+	{
+		// ms precision
+		val, err := TimeWithTimezone{}.Convert("23:02:06.745Z")
+		assert.NoError(t, err)
+
+		expectedTs := ext.NewExtendedTime(time.Date(0, 1, 1, 23, 2, 6, 745000000, time.UTC), ext.TimeKindType, "15:04:05.999999Z")
+		assert.Equal(t, expectedTs, val.(*ext.ExtendedTime))
+		assert.Equal(t, "23:02:06.745Z", val.(*ext.ExtendedTime).String(""))
+	}
+	{
+		// no fractional seconds
+		val, err := TimeWithTimezone{}.Convert("23:02:06Z")
+		assert.NoError(t, err)
+
+		expectedTs := ext.NewExtendedTime(time.Date(0, 1, 1, 23, 2, 6, 0, time.UTC), ext.TimeKindType, "15:04:05.999999Z")
+		assert.Equal(t, expectedTs, val.(*ext.ExtendedTime))
+		assert.Equal(t, "23:02:06Z", val.(*ext.ExtendedTime).String(""))
 	}
 	{
 		// Non UTC