Clean up.

artie-labs · Oct 23, 2024 · b4d2ca0 · b4d2ca0
1 parent 75aff02
commit b4d2ca0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/optimization/table_data.go b/lib/optimization/table_data.go
@@ -1,6 +1,7 @@
 package optimization
 
 import (
+	"cmp"
 	"fmt"
 	"strings"
 	"time"
@@ -273,7 +274,6 @@ func (t *TableData) MergeColumnsFromDestination(destCols ...columns.Column) erro
 
 		if found {
 			inMemoryCol.KindDetails.Kind = foundColumn.KindDetails.Kind
-
 			// Copy over backfilled
 			inMemoryCol.SetBackfilled(foundColumn.Backfilled())
 
@@ -300,8 +300,10 @@ func (t *TableData) MergeColumnsFromDestination(destCols ...columns.Column) erro
 					}
 				}
 
-				// Just copy over the type since the format wouldn't be present in the destination
+				// Copy over the type
 				inMemoryCol.KindDetails.ExtendedTimeDetails.Type = foundColumn.KindDetails.ExtendedTimeDetails.Type
+				// If the in-memory column has no format, we should use the format from the destination.
+				inMemoryCol.KindDetails.ExtendedTimeDetails.Format = cmp.Or(inMemoryCol.KindDetails.ExtendedTimeDetails.Format, foundColumn.KindDetails.ExtendedTimeDetails.Format)
 
 			}