Skip to content

Commit

Permalink
Merge branch 'master' into minor-cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
Tang8330 authored Sep 27, 2024
2 parents 09d8b3b + 0ac008e commit a37d050
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
10 changes: 2 additions & 8 deletions lib/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,7 @@ func TestConfig_Validate_ErrorTopicConfigInvalid(t *testing.T) {

defer file.Close()

_, err = io.WriteString(file,
`
outputSource: test
`)
_, err = io.WriteString(file, `outputSource: snowflake`)
assert.Nil(t, err)

config, err := readFileToConfig(randomFile)
Expand Down Expand Up @@ -179,10 +176,7 @@ func TestConfig_Validate_ErrorKafkaInvalid(t *testing.T) {

defer file.Close()

_, err = io.WriteString(file,
`
outputSource: test
`)
_, err = io.WriteString(file, `outputSource: snowflake`)
assert.Nil(t, err)

config, err := readFileToConfig(randomFile)
Expand Down
10 changes: 4 additions & 6 deletions lib/config/constants/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,21 +67,19 @@ const (
type DestinationKind string

const (
Snowflake DestinationKind = "snowflake"
Test DestinationKind = "test"
BigQuery DestinationKind = "bigquery"
MSSQL DestinationKind = "mssql"
Redshift DestinationKind = "redshift"
S3 DestinationKind = "s3"
MSSQL DestinationKind = "mssql"
Snowflake DestinationKind = "snowflake"
)

var ValidDestinations = []DestinationKind{
BigQuery,
Snowflake,
MSSQL,
Redshift,
S3,
MSSQL,
Test,
Snowflake,
}

func IsValidDestination(destination DestinationKind) bool {
Expand Down

0 comments on commit a37d050

Please sign in to comment.