Adding TODO.

artie-labs · Dec 16, 2024 · a0bd0b0 · a0bd0b0
1 parent 580ec7b
commit a0bd0b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/typing/converters/string_converter.go b/lib/typing/converters/string_converter.go
@@ -27,6 +27,7 @@ func GetStringConverter(kd typing.KindDetails) (StringConverter, error) {
 		return ArrayConverter{}, nil
 	}
 
+	// TODO: Return an error when all the types are implemented.
 	return nil, nil
 }
 

diff --git a/lib/typing/values/string.go b/lib/typing/values/string.go
@@ -7,11 +7,10 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/artie-labs/transfer/lib/typing/converters"
-
 	"github.com/artie-labs/transfer/lib/config/constants"
 	"github.com/artie-labs/transfer/lib/stringutil"
 	"github.com/artie-labs/transfer/lib/typing"
+	"github.com/artie-labs/transfer/lib/typing/converters"
 	"github.com/artie-labs/transfer/lib/typing/decimal"
 )
 
@@ -45,6 +44,8 @@ func ToString(colVal any, colKind typing.KindDetails) (string, error) {
 		return sv.Convert(colVal)
 	}
 
+	// TODO: Move all of this into converter function
+
 	switch colKind.Kind {
 	case typing.String.Kind:
 		isArray := reflect.ValueOf(colVal).Kind() == reflect.Slice
-Original file line number
+Diff line change
@@ Expand Up @@
     		return ArrayConverter{}, nil
     	}
+    	// TODO: Return an error when all the types are implemented.
     	return nil, nil
     }
@@ Expand Down @@