Skip to content

Commit

Permalink
Merge branch 'master' into nv/alpine-3.20
Browse files Browse the repository at this point in the history
  • Loading branch information
nathan-artie committed Jun 28, 2024
2 parents 3f2f963 + b33961d commit 6b3aeb0
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions clients/bigquery/storagewrite.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"google.golang.org/protobuf/types/known/timestamppb"
)

// columnToTableFieldSchema returns a [*storagepb.TableFieldSchema] suitable for transfering data of the type that the column specifies.
// columnToTableFieldSchema returns a [*storagepb.TableFieldSchema] suitable for transferring data of the type that the column specifies.
// Not that the data type is not necessarily the data type that the table in the database is using.
func columnToTableFieldSchema(column columns.Column) (*storagepb.TableFieldSchema, error) {
var fieldType storagepb.TableFieldSchema_Type
Expand Down Expand Up @@ -150,7 +150,7 @@ func rowToMessage(row map[string]any, columns []columns.Column, messageDescripto
}
message.Set(field, protoreflect.ValueOfFloat64(floatValue))
default:
return nil, fmt.Errorf("expected float32/float64/int32/int64/string recieved %T with value %v", value, value)
return nil, fmt.Errorf("expected float32/float64/int32/int64/string received %T with value %v", value, value)
}
case typing.EDecimal.Kind:
if decimalValue, ok := value.(*decimal.Decimal); ok {
Expand Down
2 changes: 1 addition & 1 deletion clients/mssql/dialect/dialect.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func (MSSQLDialect) IsTableDoesNotExistErr(err error) bool {
}

func (MSSQLDialect) BuildCreateTableQuery(tableID sql.TableIdentifier, _ bool, colSQLParts []string) string {
// Microsoft SQL Server uses the same syntax for temporary and permanant tables.
// Microsoft SQL Server uses the same syntax for temporary and permanent tables.
// Microsoft SQL Server doesn't support IF NOT EXISTS
return fmt.Sprintf("CREATE TABLE %s (%s);", tableID.FullyQualifiedName(), strings.Join(colSQLParts, ","))
}
Expand Down
2 changes: 1 addition & 1 deletion clients/redshift/dialect/dialect.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (RedshiftDialect) IsTableDoesNotExistErr(err error) bool {
}

func (RedshiftDialect) BuildCreateTableQuery(tableID sql.TableIdentifier, _ bool, colSQLParts []string) string {
// Redshift uses the same syntax for temporary and permanant tables.
// Redshift uses the same syntax for temporary and permanent tables.
return fmt.Sprintf("CREATE TABLE IF NOT EXISTS %s (%s);", tableID.FullyQualifiedName(), strings.Join(colSQLParts, ","))
}

Expand Down
2 changes: 1 addition & 1 deletion lib/config/constants/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const (
ToastUnavailableValuePlaceholder = "__debezium_unavailable_value"

// DebeziumTopicRoutingKey - https://debezium.io/documentation/reference/stable/transformations/topic-routing.html#by-logical-table-router-key-field-name
// This key is added to ensure no compaction or mutation happens since multiple tables are now going into the same topic and may have overlaping key ids.
// This key is added to ensure no compaction or mutation happens since multiple tables are now going into the same topic and may have overlapping key ids.
// We will strip this out from our partition key parsing.
DebeziumTopicRoutingKey = "__dbz__physicalTableIdentifier"

Expand Down

0 comments on commit 6b3aeb0

Please sign in to comment.