Skip to content

Commit

Permalink
[Typing] MSSQL - Use VARCHAR(MAX) instead of TEXT for decimals th…
Browse files Browse the repository at this point in the history
…at have exceeded precision (#943)
  • Loading branch information
Tang8330 authored Oct 3, 2024
1 parent 0f8910e commit 57af576
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/typing/decimal/details.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (d Details) SnowflakeKind() string {
// MsSQLKind - Has the same limitation as Redshift
// Spec: https://learn.microsoft.com/en-us/sql/t-sql/data-types/decimal-and-numeric-transact-sql?view=sql-server-ver16#arguments
func (d Details) MsSQLKind() string {
return d.toKind(MaxPrecisionBeforeString, "TEXT")
return d.toKind(MaxPrecisionBeforeString, "VARCHAR(MAX)")
}

// RedshiftKind - is used to determine whether a NUMERIC data type should be a TEXT or NUMERIC(p, s).
Expand Down

0 comments on commit 57af576

Please sign in to comment.