Kill precision and scale

artie-labs · Jun 27, 2024 · 401517e · 401517e
1 parent 91733cb
commit 401517e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 23 deletions.
diff --git a/lib/debezium/types_test.go b/lib/debezium/types_test.go
@@ -609,8 +609,8 @@ func TestField_DecodeDecimal(t *testing.T) {
 		assert.NoError(t, err)
 		assert.Equal(t, testCase.expectedValue, dec.String(), testCase.name)
 
-		assert.Equal(t, testCase.expectedPrecision, dec.Precision(), testCase.name)
-		assert.Equal(t, testCase.expectedScale, dec.Scale(), testCase.name)
+		assert.Equal(t, testCase.expectedPrecision, dec.Details().Precision(), testCase.name)
+		assert.Equal(t, testCase.expectedScale, dec.Details().Scale(), testCase.name)
 	}
 }
 
@@ -695,8 +695,8 @@ func TestField_DecodeDebeziumVariableDecimal(t *testing.T) {
 			continue
 		}
 
-		assert.Equal(t, int32(-1), dec.Precision(), testCase.name)
-		assert.Equal(t, testCase.expectedScale, dec.Scale(), testCase.name)
+		assert.Equal(t, int32(-1), dec.Details().Precision(), testCase.name)
+		assert.Equal(t, testCase.expectedScale, dec.Details().Scale(), testCase.name)
 		assert.Equal(t, testCase.expectedValue, dec.String(), testCase.name)
 	}
 

diff --git a/lib/typing/decimal/decimal.go b/lib/typing/decimal/decimal.go
@@ -23,14 +23,6 @@ func NewDecimal(value *apd.Decimal) *Decimal {
 	return NewDecimalWithPrecision(value, PrecisionNotSpecified)
 }
 
-func (d *Decimal) Scale() int32 {
-	return -d.value.Exponent
-}
-
-func (d *Decimal) Precision() int32 {
-	return d.precision
-}
-
 func (d *Decimal) Value() *apd.Decimal {
 	return d.value
 }
@@ -43,5 +35,5 @@ func (d *Decimal) String() string {
 }
 
 func (d *Decimal) Details() Details {
-	return NewDetails(d.precision, d.Scale())
+	return NewDetails(d.precision, -d.value.Exponent)
 }
diff --git a/lib/typing/decimal/decimal_test.go b/lib/typing/decimal/decimal_test.go
@@ -24,16 +24,6 @@ func TestNewDecimalWithPrecision(t *testing.T) {
 	assert.Equal(t, Details{scale: 2, precision: 4}, NewDecimalWithPrecision(numbers.MustParseDecimal("12.34"), 4).Details())
 }
 
-func TestDecimal_Scale(t *testing.T) {
-	assert.Equal(t, int32(0), NewDecimal(numbers.MustParseDecimal("0")).Scale())
-	assert.Equal(t, int32(0), NewDecimal(numbers.MustParseDecimal("12345")).Scale())
-	assert.Equal(t, int32(0), NewDecimal(numbers.MustParseDecimal("12300")).Scale())
-	assert.Equal(t, int32(1), NewDecimal(numbers.MustParseDecimal("12300.0")).Scale())
-	assert.Equal(t, int32(2), NewDecimal(numbers.MustParseDecimal("12300.00")).Scale())
-	assert.Equal(t, int32(2), NewDecimal(numbers.MustParseDecimal("12345.12")).Scale())
-	assert.Equal(t, int32(3), NewDecimal(numbers.MustParseDecimal("-12345.123")).Scale())
-}
-
 func TestDecimal_Details(t *testing.T) {
 	// -1 precision (PrecisionNotSpecified):
 	assert.Equal(t, Details{scale: 0, precision: -1}, NewDecimal(numbers.MustParseDecimal("0")).Details())