Protect against prevRow being a nil map

artie-labs · Jun 25, 2024 · 37bfb8d · 37bfb8d
1 parent 70648ec
commit 37bfb8d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/optimization/table_data.go b/lib/optimization/table_data.go
@@ -134,6 +134,9 @@ func (t *TableData) InsertRow(pk string, rowData map[string]any, delete bool) {
 		if delete {
 			// if the row was deleted, copy the previous values and just update the deleted flag
 			rowData = prevRow
+			if _, isOk := rowData[constants.DeleteColumnMarker]; !isOk {
+				rowData = map[string]any{}
+			}
 			rowData[constants.DeleteColumnMarker] = true
 		} else {
 			for key, val := range rowData {

diff --git a/lib/optimization/table_data_test.go b/lib/optimization/table_data_test.go
@@ -270,12 +270,12 @@ func TestTableData_InsertRowIntegrity(t *testing.T) {
 	assert.False(t, td.ContainOtherOperations())
 
 	for i := 0; i < 100; i++ {
-		td.InsertRow("123", map[string]any{}, true)
+		td.InsertRow("123", nil, true)
 		assert.False(t, td.ContainOtherOperations())
 	}
 
 	for i := 0; i < 100; i++ {
-		td.InsertRow("123", map[string]any{}, false)
+		td.InsertRow("123", nil, false)
 		assert.True(t, td.ContainOtherOperations())
 	}
 }