Add a TODO.

artie-labs · Apr 26, 2024 · 2966910 · 2966910
1 parent e7cbf2a
commit 2966910
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/lib/kafkalib/topic.go b/lib/kafkalib/topic.go
@@ -34,18 +34,19 @@ func GetUniqueDatabaseAndSchema(tcs []*TopicConfig) []DatabaseSchemaPair {
 }
 
 type TopicConfig struct {
-	Database                  string                      `yaml:"db"`
-	TableName                 string                      `yaml:"tableName"`
-	Schema                    string                      `yaml:"schema"`
-	Topic                     string                      `yaml:"topic"`
-	IdempotentKey             string                      `yaml:"idempotentKey,omitempty"`
-	CDCFormat                 string                      `yaml:"cdcFormat"`
-	CDCKeyFormat              string                      `yaml:"cdcKeyFormat"`
-	DropDeletedColumns        bool                        `yaml:"dropDeletedColumns"`
-	SoftDelete                bool                        `yaml:"softDelete"`
-	SkippedOperations         string                      `yaml:"skippedOperations,omitempty"`
-	IncludeArtieUpdatedAt     bool                        `yaml:"includeArtieUpdatedAt"`
-	IncludeDatabaseUpdatedAt  bool                        `yaml:"includeDatabaseUpdatedAt"`
+	Database                 string `yaml:"db"`
+	TableName                string `yaml:"tableName"`
+	Schema                   string `yaml:"schema"`
+	Topic                    string `yaml:"topic"`
+	IdempotentKey            string `yaml:"idempotentKey,omitempty"`
+	CDCFormat                string `yaml:"cdcFormat"`
+	CDCKeyFormat             string `yaml:"cdcKeyFormat"`
+	DropDeletedColumns       bool   `yaml:"dropDeletedColumns"`
+	SoftDelete               bool   `yaml:"softDelete"`
+	SkippedOperations        string `yaml:"skippedOperations,omitempty"`
+	IncludeArtieUpdatedAt    bool   `yaml:"includeArtieUpdatedAt"`
+	IncludeDatabaseUpdatedAt bool   `yaml:"includeDatabaseUpdatedAt"`
+	// TODO: Deprecate BigQueryPartitionSettings and use AdditionalMergePredicates instead.
 	BigQueryPartitionSettings *partition.BigQuerySettings `yaml:"bigQueryPartitionSettings,omitempty"`
 	AdditionalMergePredicates []partition.MergePredicates `yaml:"additionalMergePredicates,omitempty"`