Skip to content

Commit

Permalink
Merge branch 'master' into improving-mongodb-tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Tang8330 authored Sep 10, 2024
2 parents 4d9cebe + 84a1231 commit 20860dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/optimization/table_data.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ func (t *TableData) MergeColumnsFromDestination(destCols ...columns.Column) erro
// However, this will wipe the precision unit from the INTEGER which may cause integer overflow.
shouldSkip := inMemoryCol.KindDetails.Kind == typing.EDecimal.Kind && foundColumn.KindDetails.Kind == typing.Integer.Kind
if shouldSkip {
slog.Info("Skipping column", slog.String("column", inMemoryCol.Name()), slog.String("inMemoryKind", inMemoryCol.KindDetails.Kind), slog.String("foundKind", foundColumn.KindDetails.Kind))
slog.Warn("Skipping column", slog.String("column", inMemoryCol.Name()), slog.String("inMemoryKind", inMemoryCol.KindDetails.Kind), slog.String("foundKind", foundColumn.KindDetails.Kind))
} else {
// We should take `kindDetails.kind` and `backfilled` from foundCol
// We are not taking primaryKey and defaultValue because DWH does not have this information.
Expand Down

0 comments on commit 20860dd

Please sign in to comment.