Comments

clients/mssql/store.go

@@ -52,7 +52,7 @@ func (s *Store) specificIdentifierFor(topicConfig kafkalib.TopicConfig, table st
 	return NewTableIdentifier(getSchema(topicConfig.Schema), table)
 }
 
-// IdentifierFor returns a generic [types.TableIdentifier] interface for a [TopicConfig] + table name.
+// IdentifierFor returns a generic [sql.TableIdentifier] interface for a [TopicConfig] + table name.
 func (s *Store) IdentifierFor(topicConfig kafkalib.TopicConfig, table string) sql.TableIdentifier {
 	return s.specificIdentifierFor(topicConfig, table)
 }

clients/shared/sweep.go

@@ -30,7 +30,7 @@ func Sweep(dwh destination.DataWarehouse, topicConfigs []*kafkalib.TopicConfig,
 			}
 
 			if ddl.ShouldDeleteFromName(tableName) {
-				// TODO: Rewrite this to pass a [types.TableIdentifiers] to [DropTemporaryTable]
+				// TODO: Rewrite this to pass a [sql.TableIdentifiers] to [DropTemporaryTable]
 				err = ddl.DropTemporaryTable(dwh, fmt.Sprintf("%s.%s.%s", dbAndSchemaPair.Database, tableSchema, tableName), true)
 				if err != nil {
 					return err

clients/snowflake/util.go

@@ -9,7 +9,7 @@ import (
 	"github.com/artie-labs/transfer/lib/typing/columns"
 )
 
-// addPrefixToTableName will take a [types.TableIdentifier] and add a prefix in front of the table.
+// addPrefixToTableName will take a [sql.TableIdentifier] and add a prefix in front of the table.
 // This is necessary for `PUT` commands.
 func addPrefixToTableName(tableID sql.TableIdentifier, prefix string) string {
 	return tableID.WithTable(prefix + tableID.Table()).FullyQualifiedName()