Use constants

artie-labs · Jun 26, 2024 · 1a77256 · 1a77256
1 parent 43afc79
commit 1a77256
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/typing/decimal/decimal.go b/lib/typing/decimal/decimal.go
@@ -25,7 +25,7 @@ const (
 func NewDecimal(precision *int32, value *apd.Decimal) *Decimal {
 	if precision != nil {
 		scale := -value.Exponent
-		if scale > *precision && *precision != -1 {
+		if scale > *precision && *precision != PrecisionNotSpecified {
 			// Note: -1 precision means it's not specified.
 
 			// This is typically not possible, but Postgres has a design flaw that allows you to do things like: NUMERIC(5, 6) which actually equates to NUMERIC(7, 6)
@@ -58,7 +58,7 @@ func (d *Decimal) String() string {
 func (d *Decimal) Value() any {
 	// -1 precision is used for variable scaled decimal
 	// We are opting to emit this as a STRING because the value is technically unbounded (can get to ~1 GB).
-	if d.precision != nil && (*d.precision > MaxPrecisionBeforeString || *d.precision == -1) {
+	if d.precision != nil && (*d.precision > MaxPrecisionBeforeString || *d.precision == PrecisionNotSpecified) {
 		return d.String()
 	}
 

diff --git a/lib/typing/decimal/details.go b/lib/typing/decimal/details.go
@@ -10,7 +10,7 @@ type DecimalDetails struct {
 }
 
 func NewDecimalDetails(precision int32, scale int32) *DecimalDetails {
-	if scale > precision && precision != -1 {
+	if scale > precision && precision != PrecisionNotSpecified {
 		// Note: -1 precision means it's not specified.
 
 		// This is typically not possible, but Postgres has a design flaw that allows you to do things like: NUMERIC(5, 6) which actually equates to NUMERIC(7, 6)

diff --git a/lib/typing/parquet.go b/lib/typing/parquet.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/artie-labs/transfer/lib/typing/decimal"
 	"github.com/artie-labs/transfer/lib/typing/ext"
 
 	"github.com/artie-labs/transfer/lib/ptr"
@@ -113,7 +114,7 @@ func (k *KindDetails) ParquetAnnotation(colName string) (*Field, error) {
 		}, nil
 	case EDecimal.Kind:
 		precision := k.ExtendedDecimalDetails.Precision()
-		if precision == -1 {
+		if precision == decimal.PrecisionNotSpecified {
 			// This is a variable precision decimal, so we'll just treat it as a string.
 			return &Field{
 				Tag: FieldTag{