Skip to content

Commit

Permalink
Remove panics
Browse files Browse the repository at this point in the history
  • Loading branch information
nathan-artie committed Apr 22, 2024
1 parent 019e095 commit 1621ad4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions clients/bigquery/bigquery.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ func (s *Store) Label() constants.DestinationKind {
}

func (s *Store) ShouldUppercaseEscapedNames() bool {
if s.config.SharedDestinationConfig.UppercaseEscapedNames {
panic("UppercaseEscapedNames is not supported for BigQuery")
}
return false
}

Expand Down
3 changes: 0 additions & 3 deletions clients/mssql/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ func (s *Store) Label() constants.DestinationKind {
}

func (s *Store) ShouldUppercaseEscapedNames() bool {
if s.config.SharedDestinationConfig.UppercaseEscapedNames {
panic("UppercaseEscapedNames is not supported for MSSQL")
}
return false
}

Expand Down

0 comments on commit 1621ad4

Please sign in to comment.