Add tests

artie-labs · Aug 14, 2024 · 06e1e5c · 06e1e5c
1 parent ed081c4
commit 06e1e5c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/destination/ddl/expiry.go b/lib/destination/ddl/expiry.go
@@ -10,7 +10,7 @@ import (
 )
 
 func ShouldDeleteFromName(name string) bool {
-	if !strings.Contains(name, constants.ArtiePrefix) {
+	if !strings.Contains(strings.ToLower(name), constants.ArtiePrefix) {
 		return false
 	}
 

diff --git a/lib/destination/ddl/expiry_test.go b/lib/destination/ddl/expiry_test.go
@@ -2,6 +2,7 @@ package ddl
 
 import (
 	"fmt"
+	"strings"
 	"testing"
 	"time"
 
@@ -21,6 +22,8 @@ func TestShouldDeleteFromName(t *testing.T) {
 		}
 
 		for _, tblToNotDelete := range tablesToNotDrop {
+			assert.False(t, ShouldDeleteFromName(strings.ToLower(tblToNotDelete)), tblToNotDelete)
+			assert.False(t, ShouldDeleteFromName(strings.ToUpper(tblToNotDelete)), tblToNotDelete)
 			assert.False(t, ShouldDeleteFromName(tblToNotDelete), tblToNotDelete)
 		}
 	}
@@ -32,6 +35,8 @@ func TestShouldDeleteFromName(t *testing.T) {
 		}
 
 		for _, tblToDelete := range tablesToDrop {
+			assert.True(t, ShouldDeleteFromName(strings.ToLower(tblToDelete)), tblToDelete)
+			assert.True(t, ShouldDeleteFromName(strings.ToUpper(tblToDelete)), tblToDelete)
 			assert.True(t, ShouldDeleteFromName(tblToDelete), tblToDelete)
 		}
 	}