Fix MySQL snapshot error #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
approved these changes
Nov 5, 2024
Tang8330
commented
Nov 5, 2024
| if castValue == "0000-00-00" { | ||
| // MySQL supports '0000-00-00' for date columns | ||
| return nil, nil | ||
| parts := strings.Split(castValue, "-") |
There was a problem hiding this comment.
FYI @nathan-artie I just added this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We previously mapped
tinyint(1)to a boolean, this isn't accurate becausetinyint(1)can accept values that are beyond 0 and 1.What's unintuitive about this is that you can create a "boolean" column in MySQL:
Which just maps to a tinyint(1) under the hood.
Later, you can actually do this and it would be valid.
Further context
The functionality of mapping 0 and 1 to a boolean column isn't going away. If you define the downstream column as a boolean column, Transfer will automatically convert the values for 0, 1 into false / true.