Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if value scale is different from schema scale #477

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Warn if value scale is different from schema scale #477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c061a8f
Warn if value scale is different from schema scale
nathan-artie Aug 23, 2024
3b2ef40
Change word
nathan-artie Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/debezium/converters/decimal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package converters

import (
"fmt"
"log/slog"

"github.com/artie-labs/transfer/lib/debezium"
"github.com/artie-labs/transfer/lib/typing"
Expand Down Expand Up @@ -40,6 +41,14 @@ func decimalWithNewExponent(decimal *apd.Decimal, newExponent int32) *apd.Decima
func encodeDecimalWithScale(decimal *apd.Decimal, scale int32) []byte {
targetExponent := -scale // Negate scale since [Decimal.Exponent] is negative.
if decimal.Exponent != targetExponent {
// TODO: We may be able to remove this conversion and just return an error to maintain parity with `org.apache.kafka.connect.data.Decimal`
// https://github.com/a0x8o/kafka/blob/54eff6af115ee647f60129f2ce6a044cb17215d0/connect/api/src/main/java/org/apache/kafka/connect/data/Decimal.java#L69
slog.Warn("Value scale is different from schema scale",
slog.Any("value", decimal.Text('f')),
slog.Any("actual", -decimal.Exponent),
slog.Any("expected", scale),
)

decimal = decimalWithNewExponent(decimal, targetExponent)
}
bytes, _ := debezium.EncodeDecimal(decimal)
Expand Down
Loading