Move encodeDecimalWithScale from transfer
#476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Aug 23, 2024
| "github.com/artie-labs/transfer/lib/debezium" | ||
| "github.com/artie-labs/transfer/lib/typing" | ||
| "github.com/cockroachdb/apd/v3" | ||
| ) | ||
|
|
||
| // decimalWithNewExponent takes a [*apd.Decimal] and returns a new [*apd.Decimal] with a the given exponent. |
There was a problem hiding this comment.
No changes to these two functions.
nathan-artie
changed the title
encodeDecimalWithScale from transferencodeDecimalWithScale from transfer
nathan-artie
commented
Aug 23, 2024
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestDecimalWithNewExponent(t *testing.T) { |
There was a problem hiding this comment.
No changes to these tests other than changing the case of encodeDecimalWithScale.
danafallon
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy
decimalWithNewExponentandencodeDecimalWithScalefrom transfer so that they can be removed from transfer.Since
decimalWithNewExponentis somewhat opinionated (it truncates extra digits rather rounding or returning an error) it makes more sense to have it reader where it is used so that we can decide which behavior is ideal.