DynamoDB - Respect lineage #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danafallon
reviewed
Jun 27, 2024
sources/dynamodb/shard.go
Outdated
| if parentID := shard.ParentShardId; parentID != nil { | ||
| // If the parent shard exists, is it still being processed? If so, let's wait a bit and then retry. | ||
| // We must process the parent shard first before processing the child shard. | ||
| if s.storage.GetShardProcessing(*parentID) && !s.storage.GetShardProcessed(*parentID) { |
There was a problem hiding this comment.
What if the parent hasn't started processing yet? Is that possible?
There was a problem hiding this comment.
Hm interesting. I think we need to sort the shards that are returned since there's no guarantee it's ordered
danafallon
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an edge case with DynamoDB where if the same record appeared in two different DynamoDB shards (parent -> child), we are processing them in parallel as opposed to sequentially.
This is mainly an issue if a DynamoDB stream hasn't been consumed in a while since shards are records and time based.
Per SDK docs: