Clean up.

artie-labs · Oct 5, 2024 · c8c902a · c8c902a
1 parent 13208da
commit c8c902a
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/sources/postgres/adapter/adapter.go b/sources/postgres/adapter/adapter.go
@@ -90,6 +90,10 @@ func valueConverterForType(dataType schema.DataType, opts *schema.Opts) (convert
 
 		return converters.NewBitConverter(opts.CharMaxLength), nil
 	case schema.BitVarying:
+		if opts == nil {
+			return nil, fmt.Errorf("missing options for bit varying data type")
+		}
+
 		return converters.NewBitVaryingConverter(opts.CharMaxLength), nil
 	case schema.Boolean:
 		return converters.BooleanPassthrough{}, nil

diff --git a/sources/postgres/adapter/adapter_test.go b/sources/postgres/adapter/adapter_test.go
@@ -301,5 +301,30 @@ func TestValueConverterForType_Convert(t *testing.T) {
 			assert.Equal(t, []byte{21}, actualValue)
 		}
 	}
+	{
+		// bit varying
+		{
+			// no options
+			_, err := valueConverterForType(schema.BitVarying, nil)
+			assert.ErrorContains(t, err, "missing options for bit varying data type")
+		}
+		{
+			// bit varying
+			converter, err := valueConverterForType(schema.BitVarying, &schema.Opts{CharMaxLength: 0})
+			assert.NoError(t, err)
+
+			actualValue, actualErr := converter.Convert("1")
+			assert.NoError(t, actualErr)
+			assert.Equal(t, []byte{1}, actualValue)
+		}
+		{
+			// bit varying (5)
+			converter, err := valueConverterForType(schema.BitVarying, &schema.Opts{CharMaxLength: 5})
+			assert.NoError(t, err)
 
+			actualValue, actualErr := converter.Convert("10101")
+			assert.NoError(t, actualErr)
+			assert.Equal(t, []byte{21}, actualValue)
+		}
+	}
 }