Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web Analytics documentation. (#230) #246

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

melaniekung
Copy link
Contributor

@melaniekung melaniekung commented Nov 9, 2023

No description provided.

@melaniekung melaniekung self-assigned this Nov 9, 2023
@melaniekung melaniekung added the admin manual The issue affects content in the Administrator manual label Nov 9, 2023
@melaniekung melaniekung linked an issue Nov 9, 2023 that may be closed by this pull request
@melaniekung melaniekung added this to the 2.8 milestone Nov 13, 2023
Copy link
Contributor

@fiver-watson fiver-watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@melaniekung melaniekung requested review from anvit and removed request for jraddaoui and sbreker November 16, 2023 19:26
@melaniekung melaniekung changed the title Update Web Analytics documentation. (#230) WIP Update Web Analytics documentation. (#230) Nov 16, 2023
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, but looks good otherwise! Great job Mel!

@@ -223,31 +197,16 @@ Let's begin!
Google Analytics web property setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they still call it web property or should this section title be changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! thanks

@melaniekung melaniekung merged commit d4b069b into 2.7 Nov 20, 2023
2 checks passed
@melaniekung melaniekung deleted the dev/issue-230-web-analytics branch November 20, 2023 15:59
anvit pushed a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin manual The issue affects content in the Administrator manual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Web Analytics page is outdated after release of G4 update
3 participants