Prefetch related models in FPR views #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values of the `The related output format` field are string representations of the Format models. The __str__ method of the Format model prints its related FormatGroup. This prefetches the FormatGroup models in advance in the queryset of the field so it doesn't require separate queries for each Format.
replaceafill
added
AMAUAT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many views in the FPR have the N+1 Queries problem where multiple/separate queries are created to select single related rows in the database. For example, to create an FPR rule every single
Formatis retrieved separately, and after its relatedFormatGroup.This PR adds prefetch_related calls to specific
QuerySets in views and forms to retrieve the related models beforehand.