Remove vcrpy #1868
Closed
Remove vcrpy #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vcrpy4.3.1 started pinning itsurllib3dependency for Python versions lower than 3.10. Besides from preventing us from upgradingurllib3ourselves, this also makespip-compileto generate production and development requirements files with different versions.This PR removes the
vcrpydependency and its yaml cassette files and replace them with mocks. Some mock set ups and assertions are really verbose because they were generated from the cassette interactions, but I plan to trim them down to contain only the fields needed by each test.