Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: password prompt deleted - shell makefile for linux users #60

Merged
merged 2 commits into from
May 21, 2021

Conversation

louispaga
Copy link
Contributor

@louispaga louispaga commented Apr 24, 2021

Issue

resolves #57

Description

###Tests

  • I deployed the infra and checked if the changes were saved.
  • The changes within the makefile were just tested on GNU and it was ok. Maybe a deployment test on another OS is necessary. Will take care of this in the next few days.

@louispaga louispaga requested a review from AlexisVLRT April 26, 2021 09:52
@AlexisVLRT
Copy link
Collaborator

Hey, sorry for the super late review. Thanks for the contribution though, the code looks good !

Could you edit your PR message to indicate the issue you're resolving by adding resolves #XX to the message ? It helps for automation.
Also can you explicit what you did to test your feature ?

Thanks !

louispaga added 2 commits May 14, 2021 18:35
the database password is now generated automatically and treated as
sensitive by default.
the default shell for makefiles for GNU users is sh and it does not
include the "source" command.
@AlexisVLRT AlexisVLRT merged commit ff131e8 into master May 21, 2021
@AlexisVLRT AlexisVLRT deleted the 57_dbpassword branch May 21, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As A User, I do not want to have to enter a password for the SQL database.
2 participants